fix: cut docs version nav from Edge so new pages aren't dropped#6349
Conversation
There was a problem hiding this comment.
Summary: This PR updates documentation version navigation generation to clone from the Edge entry and adds corresponding documentation navigation entries/tests. No exploitable security vulnerabilities were identified.
Risk: Low risk. The changes affect documentation metadata and internal release tooling, with no new public attack surface, authentication changes, authorization logic, or sensitive data handling.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe docs freeze flow now clones Edge navigation for new versions, rewrites Edge page paths into the frozen version, and updates fixture data and tests for a Datadog Edge page. ChangesEdge-based docs freeze
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
0ff2316 to
e15f5fe
Compare
The docs cut copied every Edge file into the new `docs/v<X.Y.Z>/` snapshot but built that version's `docs.json` navigation by cloning the previous frozen release and only rewriting path prefixes. Pages added to Edge since the last release were therefore copied to disk yet never linked in the version selector, which is why the v1.15.0 cut shipped without the Datadog guide. `_build_new_entry` now clones the Edge nav entry and rewrites `edge/<locale>/` to `v<new>/<locale>/`, so promoting Edge to Latest carries every current page and nav restructuring.
The v1.15.0 freeze copied `enterprise/guides/datadog` into the snapshot for every locale but never linked it in `docs.json`, because the cut cloned the v1.14.7 nav instead of Edge. This backfills the missing nav reference in the `en`, `pt-BR`, `ko`, and `ar` v1.15.0 blocks so the already-shipped page is reachable from the version selector. Pairs with the `_build_new_entry` fix that prevents future cuts from dropping pages.
The v1.15.1 cut ran before the freeze-from-Edge fix landed, so it inherited the same bug as v1.15.0: `enterprise/guides/datadog` was copied into the snapshot for every locale but never linked in `docs.json`. This backfills the missing nav reference in the `en`, `pt-BR`, `ko`, and `ar` v1.15.1 blocks so the page is reachable from the version selector.
7b85bad to
9fd3c53
Compare
The docs release cut promotes Edge → Latest, but the navigation half of that
promotion read the wrong source.
_copy_snapshotcorrectly copied everydocs/edge/<locale>/file intodocs/v<X.Y.Z>/, while_build_new_entryregistered the new version's
docs.jsonnav by cloning the previous frozenrelease and rewriting path prefixes. Any page added to Edge since the last
release was therefore written to disk but never linked in the version
selector. This is why v1.15.0 shipped without the Datadog guide
(
enterprise/guides/datadog) in all four locales, even though the files werepresent in the snapshot.
Note
Low Risk
Changes are limited to docs-site config and the devtools docs-freeze helper, with no impact on runtime product code.
Overview
Fixes a mismatch in the docs Edge → Latest freeze: file copies already came from
docs/edge/, butdocs.jsonnavigation for the new version was cloned from the previous frozen release. Pages added to Edge after the last cut (e.g. the Datadog enterprise guide) were copied into the snapshot but missing from the version selector.crewai_devtools.docs_versioningnow builds the new Latest entry from the Edge nav (_edge_entry/_build_new_entry), rewriting pathsedge/...→v<X.Y.Z>/.... A regression test covers a page present in Edge but absent from the old frozen nav.docs/docs.jsonaddsenterprise/guides/datadogunder enterprise guides for v1.15.0 and v1.15.1 across en, pt-BR, ko, and ar so those releases expose the guide in the nav.Reviewed by Cursor Bugbot for commit 9fd3c53. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
New Features
datadogentries) across multiple locales and versions.Bug Fixes
Tests